Skip to content

feat: enhance Kubernetes client with watch functionality #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 22 commits into from
Closed

feat: enhance Kubernetes client with watch functionality #1666

wants to merge 22 commits into from
+213 −33

Conversation

lqlive
Copy link
Contributor

@lqlive lqlive commented Sep 12, 2025 •
edited
Loading

Base on #1662
@tg123 Hi ,This is my initial implementation. Could you help me see how much it differs from your ideas?

During my implementation, I thought of two issues:

1.Can the ListNamespacedPodWithHttpMessagesAsync method be set as protected or private to prevent external access?

2.Replace the tuple (WatchEventType, V1Pod) in IAsyncEnumerable<(WatchEventType, V1Pod)> with a new type, such as:

public readonly struct ResourceEvent<TResource>(EventType eventType, TResource value, TResource oldValue = default!)
{
    public EventType EventType { get; } = eventType;
    public TResource OldValue { get; } = oldValue;
    public TResource Value { get; } = value;
}

public enum EventType
{
    Unknown = 0,
    Created = 1,
    Updated = 2,
    Deleted = 3
}

lqlive and others added 21 commits April 18, 2025 17:44
@lqlive
fix typo
128bc43
@lqlive
Merge branch 'kubernetes-client:master' into master
f021a01
@lqlive
Merge branch 'kubernetes-client:master' into master
19cbf1d
@lqlive
Add modular API
2cf1a53
@lqlive
Use x-kubernetes-action instead of operationId to generate method names
0bd3dad
@lqlive
fix
7a3f951
@lqlive
Clean code style warnings
1347826
@lqlive
Refactor client constructors to use Kubernetes type instead of IKuber…
47b8330 
…netes
@lqlive
Add ClientSet tests for Kubernetes pod operations
05da1c4
@lqlive
Fix order of parameters in Pod API calls for consistency
56f63e5
@lqlive
Enhance documentation for ClientSet and ResourceClient classes
5c3f9a4
@lqlive
Refactor ClientSet and GroupClient for Kubernetes usage
177809d
@lqlive
Refactor Pod API calls in tests to use singular form for consistency
3085283
@lqlive
Refactor Pod API calls to use 'Create' and 'Update' methods for consi…
218bb31 
…stency
@lqlive
Merge branch 'kubernetes-client:master' into master
bd0ee36
feat: enhance Kubernetes client with watch functionality
cab4f39 
- Reintroduced Watcher.cs and WatcherExt.cs in the AOT project.
- Added FilterParameters and GetParameterValueForWatchCall methods in ParamHelper to support filtering parameters and handling watch calls.
- Updated OperationsExtensions template to include new watch methods with appropriate XML documentation for parameters.

This update improves the Kubernetes client by enabling watch capabilities for operations, enhancing the overall functionality.
@lqlive
refactor: rename GetParameterValueForWatchCall to GetParameterValueFo…
d2b4370 
…rWatch and update templates
@lqlive
refactor: update templates to utilize filtered parameters for watch f…
43780e8 
…unctionality
@lqlive
refactor: update GetParameterValueForWatch to accept a watch flag and…
38c7ae7 
… adjust templates accordingly
@lqlive
refactor: simplify Kubernetes pod watch implementation and enhance er…
daf7790 
…ror handling
@lqlive
refactor: enhance Program.cs with pod watch functionality and code cl…
bc0acaa 
…eanup
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2025
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Sep 12, 2025 •
edited
Loading

CLA Missing ID CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lqlive
Once this PR has been reviewed and has the lgtm label, please assign tg123 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 12, 2025
@lqlive lqlive closed this by deleting the head repository Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@tg123 tg123 Awaiting requested review from tg123

Assignees
No one assigned
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lqlive @k8s-ci-robot